generalize IntegratedStraightLineProgram
#3104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBreuer
added
kind: enhancement
|
I'm always tempted to ask "could there be some tests". While I realise there is an example, does it cover all the new cases? I realise this request might seem annoying for fairly small change. |
- extended `IntegratedStraightLineProgram` to the situation that some of the input programs return lists of elements, - adjusted the documentation of `IntegratedStraightLineProgram` accordingly, - mention in the documentation of `StraightLineProgram` that the given list of lines or string must be nonempty (the code has never allowed empty input data) - added some tests for the extension
ThomasBreuer
force-pushed
the
TB_IntegratedStraightLineProgram
branch
from
e5e4222
to
47b90a2
Compare
Codecov Report
@@ Coverage Diff @@
## master #3104 +/- ##
==========================================
- Coverage 83.55% 83.55% -0.01%
==========================================
Files 686 686
Lines 336665 336753 +88
==========================================
+ Hits 281317 281390 +73
- Misses 55348 55363 +15
|
|
@ChrisJefferson Thanks for your comment. |
ChrisJefferson
approved these changes
Dec 18, 2018
DominikBernhardt
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extended
IntegratedStraightLineProgramto the situationthat some of the input programs return lists of elements,
adjusted the documentation of
IntegratedStraightLineProgramaccordingly,
mention in the documentation of
StraightLineProgramthat the given list of lines or string must be nonempty
(the code has never allowed empty input data)