Fix ShallowCopy for KnuthBendixRewritingSystem #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll push some tests this afternoon. |
Codecov Report
@@ Coverage Diff @@
## master #3128 +/- ##
==========================================
+ Coverage 83.58% 83.6% +0.01%
==========================================
Files 687 687
Lines 336919 336920 +1
==========================================
+ Hits 281619 281673 +54
+ Misses 55300 55247 -53
|
markuspf
added
kind: bug: unexpected error
fingolfin
reviewed
Dec 21, 2018
tst/testinstall/knuthbendix.tst
Outdated
| @@ -0,0 +1,95 @@ | |||
| gap> START_TEST("knuthbendix.tst"); | |||
There was a problem hiding this comment.
Since this only contains tests for code in kbsemi.gi, perhaps kbsemi.tst would be the more appropriate filename?
ShallowCopy did not copy the components `freefam`, `ordering` and `tzordering` of a KnuthBendixRewritingSystem, and hence cause an error if a rewriting system was ShallowCopied and used afterwards.
`IsReduced` did not work for KnuthBendixRewritingSystems, because it used `Rules` to obtain the rules of a rewriting system which are stored as `IsLetterAssocWordRep`, and then tried reducing words using a kernel function that assumes list access is possible for such words (which it is not). Use TzRules instead which converts rules to lists of integers.
fingolfin
approved these changes
Dec 29, 2018
olexandr-konovalov
added
release notes: added
fingolfin
added
the
kind: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3108
If anyone wants to write some more tests, both with and without ShallowCopying, that would be good, as this is not an area I'm expert in and no-one has touched it in quite a long time.