Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IsHomogeneousList for empty string (should return true, returned false) #3189

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Fix IsHomogeneousList for empty string (should return true, returned false) #3189

merged 2 commits into from
Jan 17, 2019

Conversation

fingolfin
Copy link
Member

Also split a .tst file (see commit message for explanation)

@fingolfin
tests: move part of strings.tst to new stringobj.tst
3053e83 
The old file tests the functions String/ViewString/PrintString/...,
the new one tests functionality of strings in IsStringRep
@fingolfin
kernel: fix IsHomogeneousList for empty strings
4b8e50b 
It should return true, but erroneously returned false.
@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them topic: kernel release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Jan 17, 2019
@fingolfin
Copy link
Member Author

The test failure is due to bug #3187 and thus fixed by PR #3191

markuspf
markuspf approved these changes Jan 17, 2019
View reviewed changes
Copy link
Member

@markuspf markuspf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except that I do not understand why the empty string would ever have been non-homogeneous.

@fingolfin
Copy link
Member Author

Not sure which "level" of "why" you are referring. Do you mean: why did anybody ever think the empty string should not be homogeneous? (Likely answer: because humans make mistakes?).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.877% when pulling 4b8e50b on fingolfin:mh/fix-IsHomogeneousList-strings into e0ac2e5 on gap-system:master.

@fingolfin fingolfin merged commit 6a2a7ac into gap-system:master Jan 17, 2019
@fingolfin fingolfin deleted the mh/fix-IsHomogeneousList-strings branch January 17, 2019 23:41
@fingolfin fingolfin added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Apr 15, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuspf markuspf markuspf approved these changes

@ChrisJefferson ChrisJefferson Awaiting requested review from ChrisJefferson

Assignees
No one assigned
Labels
kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel
Projects
None yet
Milestone
GAP 4.11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fingolfin @coveralls @markuspf @olexandr-konovalov