Fix Display for functions with large literals, and add a bunch of tests #3207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: bug
Test large float literals, ensure ReadEvalError in function calls gets reliably triggered, and also test bounds checks for ranges in gac compiled code.
This fixes a problem where printing functions with long literals would
wrap those literals badly. As an example, before this fix, we got:
gap> SizeScreen([60,100]);;
gap> Display(f->12345678901234567890123456789012345678901234567890123456789012345678901234567890);
function ( f )
return
12345678901234567890123456789012345678901234567890123\
\
456789012345678901234567890;
end
With this fix, we get:
gap> SizeScreen([60,100]);;
gap> Display(f->12345678901234567890123456789012345678901234567890123456789012345678901234567890);
function ( f )
return
12345678901234567890123456789012345678901234567890123\
456789012345678901234567890;
end
Fixes gap-system#3205
fingolfin
force-pushed
the
mh/display-funcs
branch
from
2edea3f
to
eb1829c
Compare
Codecov Report
@@ Coverage Diff @@
## master #3207 +/- ##
==========================================
+ Coverage 84.76% 84.77% +<.01%
==========================================
Files 687 687
Lines 335865 335867 +2
==========================================
+ Hits 284696 284722 +26
+ Misses 51169 51145 -24
|
ChrisJefferson
approved these changes
Jan 22, 2019
DominikBernhardt
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was writing a bunch of tests when I noticed this odd printing behavior. So this PR first adds a bunch of tests; and then a commit which fixes
Displayfor functions which large literals (and which also adjusts the tests added in the first commit accordingly).