CloseMutableBasis now returns something
#3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up to now, `CloseMutableBasis` had no return value. Now it returns `true` if the basis was extended and `false` otherwise. This saves work in situations where one builds a basis by adding vectors, and where one wants to know which ones really extended the current basis.
Codecov Report
@@ Coverage Diff @@
## master #3247 +/- ##
==========================================
- Coverage 85.09% 85.09% -0.01%
==========================================
Files 695 695
Lines 344336 344346 +10
==========================================
+ Hits 293024 293032 +8
- Misses 51312 51314 +2
|
1 similar comment
fingolfin
added
kind: enhancement
PaulaHaehndel
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now,
CloseMutableBasishad no return value.Now it returns
trueif the basis was extended andfalseotherwise.This saves work in situations where one builds a basis by
adding vectors, and where one wants to know which ones really
extended the current basis.