Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve gac to preserve argument names of compiled functions #3252

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Improve gac to preserve argument names of compiled functions #3252

merged 1 commit into from
Jan 30, 2019

Conversation

fingolfin
Copy link
Member

Fix #3240

@fingolfin fingolfin added the topic: gac GAP to C compiler label Jan 29, 2019
@codecov
Copy link

codecov bot commented Jan 30, 2019 •
edited
Loading

Codecov Report

Merging #3252 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3252      +/-   ##
==========================================
- Coverage   85.12%    85.1%   -0.02%     
==========================================
  Files         695      696       +1     
  Lines      342498   344598    +2100     
==========================================
+ Hits       291546   293286    +1740     
- Misses      50952    51312     +360
Impacted Files Coverage Δ
src/c_type1.c 86.38% <100%> (-0.71%) ⬇️
src/hpc/c_type1.c 86.86% <100%> (ø) ⬆️
src/c_oper1.c 93.19% <100%> (-0.19%) ⬇️
src/compiler.c 89.14% <100%> (-0.63%) ⬇️
src/hpc/c_oper1.c 93.12% <100%> (ø) ⬆️
src/io.c 80.95% <0%> (-2.61%) ⬇️
src/hookintrprtr.c 67.34% <0%> (-2.55%) ⬇️
src/system.c 73.73% <0%> (-1.86%) ⬇️
src/libgap-api.c 25.87% <0%> (-1.54%) ⬇️
src/vecffe.c 80.81% <0%> (-1.48%) ⬇️
... and 83 more

@coveralls
Copy link

coveralls commented Jan 30, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 84.961% when pulling 3d6320b on fingolfin:mh/gac-arg-names into d5e7625 on gap-system:master.

@fingolfin fingolfin merged commit 0b75f03 into gap-system:master Jan 30, 2019
@fingolfin fingolfin deleted the mh/gac-arg-names branch January 31, 2019 08:57
@fingolfin fingolfin added the kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements label Apr 15, 2019
@markusbaumeister markusbaumeister added the release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes label Apr 16, 2019
@fingolfin fingolfin changed the title gac: preserve argument names of compiled functions Improve gac to preserve argument names of compiled functions Aug 22, 2019
@fingolfin fingolfin added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Aug 22, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisJefferson ChrisJefferson ChrisJefferson approved these changes

Assignees
No one assigned
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes topic: gac GAP to C compiler
Projects
None yet
Milestone
GAP 4.11.0
Development

Successfully merging this pull request may close these issues.

Teach gac to preserve function argument names
5 participants
@fingolfin @coveralls @ChrisJefferson @olexandr-konovalov @markusbaumeister