Add explanation for workaround of #3346

[wucas]

Adds an explanation for a workaround for #3346 to INSTALL.md. This way it might be easier to find an explanation if others have the same issue.

[coveralls]

Coverage remained the same at 85.151% when pulling a4f5aa9 on wucas:lw/improve-INSTALL.md into 38aa4e8 on gap-system:master.

[fingolfin]

Thanks! Some minor remarks attached. Is this in three commits on purpose?

[olexandr-konovalov]

Making Problems specific to Windows more visible looks good to me. I didn't know that The ^-key or "-key cannot be entered may also happen on other systems.

Looks good to me, although I can't check all macOS instructions. Note that on my Mac I have to call make with CFLAGS as below:

export CC=/usr/local/bin/gcc-7
./configure --with-readline=/usr/local/opt/readline/
make CFLAGS="-isystem /usr/local/opt/readline/include/"

Finally, would be nice to change OS X to macOS which is now the official name.

[wucas]

Thanks! Some minor remarks attached. Is this in three commits on purpose?

No not on purpose I just was not aware of the right workflows, I squashed them.

[wucas]

@alex-konovalov I've also changed OS X to macOS. For consistency I changed it in the README.md too.

[fingolfin]

@wucas minor thing: your commits show up with different names. One has author Lucas Wollenhaupt <reg-github@wucas.de> and one has Lucas Wollenhaupt <github@wucas.de> Is that intentional? If you want to use both addresses, I recommend to add both to your GitHub profile, so that GitHub can correctly associate your commits to your GitHub account.

[fingolfin]

Thanks, looks pretty good to me; just three minor comments, and a note on the authorship of your commits.

That said, I wouldn't complain if we merged this as-is either shrug

[codecov]

Codecov Report

Merging #3348 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3348      +/-   ##
==========================================
- Coverage   85.15%   85.15%   -0.01%     
==========================================
  Files         697      697              
  Lines      344057   344057              
==========================================
- Hits       292976   292968       -8     
- Misses      51081    51089       +8

Impacted Files	Coverage Δ
src/iostream.c	65.39% <0%> (-0.77%)	⬇️
src/system.c	73.5% <0%> (-0.32%)	⬇️
src/modules.c	76.53% <0%> (-0.23%)	⬇️
src/stats.c	94.93% <0%> (-0.21%)	⬇️
src/io.c	79.18% <0%> (-0.18%)	⬇️
src/objects.c	81.33% <0%> (-0.14%)	⬇️
src/plist.c	93.18% <0%> (-0.09%)	⬇️

[fingolfin]

Perfect, thank you!