Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve discoverability of "rewriteToFile" option in "Test" #3360

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Improve discoverability of "rewriteToFile" option in "Test" #3360

merged 1 commit into from
Mar 21, 2019

Conversation

AnnaKDS
Copy link

@AnnaKDS AnnaKDS commented Mar 20, 2019

Fixes #3345

@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: documentation Issues and PRs related to documentation gapdays2019-spring Issues and PRs that arose at https://www.gapdays.de/gapdays2019-spring labels Mar 20, 2019
fingolfin
fingolfin requested changes Mar 20, 2019
View reviewed changes
lib/test.gi Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #3360 into master will decrease coverage by 15.92%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #3360       +/-   ##
===========================================
- Coverage   85.15%   69.23%   -15.93%     
===========================================
  Files         697      633       -64     
  Lines      344057   305908    -38149     
===========================================
- Hits       292976   211782    -81194     
- Misses      51081    94126    +43045
Impacted Files Coverage Δ
lib/test.gi 77.67% <ø> (-3.08%) ⬇️
src/pperm.h 0% <0%> (-90.33%) ⬇️
src/tietze.c 1.11% <0%> (-88.99%) ⬇️
src/syntaxtree.c 11.47% <0%> (-88.53%) ⬇️
src/trans.h 0% <0%> (-85.72%) ⬇️
lib/ctblauto.gi 5.98% <0%> (-83.31%) ⬇️
src/vec8bit.c 1% <0%> (-81.63%) ⬇️
src/compiler.c 8.06% <0%> (-80.61%) ⬇️
lib/ctbllatt.gi 4.94% <0%> (-79.62%) ⬇️
src/dteval.c 3.1% <0%> (-78.24%) ⬇️
... and 393 more

wilfwilson
wilfwilson approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the changes, thank you.

fingolfin
fingolfin approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looking good now...

... except that a test fails, because that test involves some line numbers in test.gi, which now are changed by your nice PR... sigh.

You can resolve this by changing into the tst/testspecial subdirectory, then run ./regenerate_tests.sh -- this should update the relevant file, and you can simply add (amend) it to your commit.

@fingolfin
Copy link
Member

@AnnaKDS alternatively, I can also fix up this PR for you, but I did not want to do this "behind your back". Let me know what you prefer.

@AnnaKDS
Copy link
Author

AnnaKDS commented Mar 21, 2019

Thank you for the help. I commited the relevant file and hopefully, the tests will go through now.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0006%) to 85.146% when pulling 921f99b on AnnaKDS:AS/Improve-doc-Test into 31d7def on gap-system:master.

@fingolfin fingolfin merged commit e3ac220 into gap-system:master Mar 21, 2019
@fingolfin
Copy link
Member

Thank you!

@AnnaKDS AnnaKDS deleted the AS/Improve-doc-Test branch March 21, 2019 10:28
@PaulaHaehndel PaulaHaehndel added the release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes label Apr 15, 2019
@DominikBernhardt DominikBernhardt added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Aug 21, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

@wilfwilson wilfwilson wilfwilson approved these changes

Assignees
No one assigned
Labels
gapdays2019-spring Issues and PRs that arose at https://www.gapdays.de/gapdays2019-spring kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes topic: documentation Issues and PRs related to documentation
Projects
None yet
Milestone
GAP 4.11.0
Development

Successfully merging this pull request may close these issues.

Improve discoverability of "rewriteToFile" option in ´Test´
7 participants
@AnnaKDS @fingolfin @coveralls @wilfwilson @olexandr-konovalov @DominikBernhardt @PaulaHaehndel