documentation of IsPrimitive improved

[PaulaHaehndel]

I added some information in the documentation of IsPrimitive.
While doing so I noticed that in the explanation of "xset" (external set) in the begin of the section "extset" was used that has no appearence in the rest of the document. So I changed it.
Closes #3329

[wilfwilson]

I believe this resolves the remaining problems in Issue #3329. Is that right @PaulaHaehndel, or is there still stuff mentioned in that issue that should be fixed?

[fingolfin]

Thank you, much appreciated! I have some remarks and questions, though.

[fingolfin]

I am confused by this remark. Why would it tell that?

[PaulaHaehndel]

It never would, but as a naive user you could think that IsPrimitive for a matrix group actually tells you whether this group is a primitive matrix group. But this is not the case.

[fingolfin]

OK, I did not make this connection, so this paragraph, which is meant as a clarification, to me was instead confusing :/. Perhaps it could be changed to something more like this: "This operation is not concerned with the notion of "primitive vector space", i.e., it does not..."

[PaulaHaehndel]

@wilfwilson

I believe this resolves the remaining problems in Issue #3329. Is that right @PaulaHaehndel, or is there still stuff mentioned in that issue that should be fixed?

yes it solves the remaining problems, but it still would be nice to get the information that you tried to use Blocks for an intransitive group.

[wilfwilson]

The blocks problem is now its own issue: #3364.

[wilfwilson]

I'm happy with this. Thanks!

[PaulaHaehndel]

The blocks problem is now its own issue: #3364.

Then the issue: #3329 can be closed when this PR is merged.

[coveralls]

Coverage remained the same at 85.146% when pulling 923eebf on PaulaHaehndel:doc into e3ac220 on gap-system:master.

[fingolfin]

If you put "Closes #3329" or "Fixes #3329" or "Resolves #3329" into the issue description (not the title), then merging this PR will automatically close the issue -- see https://help.github.com/en/articles/closing-issues-using-keywords

[PaulaHaehndel]

If you put "Closes #3329" or "Fixes #3329" or "Resolves #3329" into the issue description (not the title), then merging this PR will automatically close the issue -- see https://help.github.com/en/articles/closing-issues-using-keywords

@fingolfin did so. Is there anything else that has to be fixed with this PR?

[codecov]

Codecov Report

Merging #3363 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3363      +/-   ##
==========================================
- Coverage   85.14%   85.14%   -0.01%     
==========================================
  Files         697      697              
  Lines      344047   344064      +17     
==========================================
+ Hits       292950   292962      +12     
- Misses      51097    51102       +5

Impacted Files	Coverage Δ
lib/oprt.gd	95.34% <ø> (ø)	⬆️
src/system.c	73.5% <0%> (-0.32%)	⬇️
src/modules.c	76.53% <0%> (-0.23%)	⬇️
src/io.c	77.42% <0%> (-0.18%)	⬇️
src/objects.c	81.33% <0%> (-0.14%)	⬇️
src/plist.c	93.18% <0%> (-0.09%)	⬇️
lib/test.gi	80.74% <0%> (ø)	⬆️
src/trans.cc	99.8% <0%> (ø)	⬆️
lib/matint.gi	84.02% <0%> (+0.02%)	⬆️

[wilfwilson]

Thanks!