Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that InputTextFile should not be used for binary files #3374

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Document that InputTextFile should not be used for binary files #3374

merged 1 commit into from
Mar 25, 2019

Conversation

ChrisJefferson
Copy link
Contributor

This is the second part of a "fix" for handing windows line endings.

The parsing was improved, but we still can't use InputTextFile to parse binary files. Document this fact and point people to IO_File for such needs.

Fixes #3273

@wucas wucas added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them topic: documentation Issues and PRs related to documentation and removed kind: bug Issues describing general bugs, and PRs fixing them kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them labels Mar 23, 2019
@coveralls
Copy link

coveralls commented Mar 24, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 85.138% when pulling bc0da80 on ChrisJefferson:tiny-doc into 49bec58 on gap-system:master.

fingolfin
fingolfin approved these changes Mar 24, 2019
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Two minor nitpicks, but could also merge as-is shrug

lib/streams.gd Outdated Show resolved Hide resolved
lib/streams.gd Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 25, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@49bec58). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3374   +/-   ##
=========================================
  Coverage          ?   85.33%           
=========================================
  Files             ?      696           
  Lines             ?   342429           
  Branches          ?        0           
=========================================
  Hits              ?   292205           
  Misses            ?    50224           
  Partials          ?        0
Impacted Files Coverage Δ
lib/streams.gd 96.87% <ø> (ø)

@fingolfin fingolfin merged commit 6424be9 into gap-system:master Mar 25, 2019
@PaulaHaehndel PaulaHaehndel added the release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes label Apr 15, 2019
@ChrisJefferson ChrisJefferson deleted the tiny-doc branch May 8, 2019 16:53
@DominikBernhardt DominikBernhardt added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Aug 22, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes topic: documentation Issues and PRs related to documentation
Projects
None yet
Milestone
GAP 4.11.0
Development

Successfully merging this pull request may close these issues.

ReadByte doesn't read a byte
7 participants
@ChrisJefferson @coveralls @fingolfin @olexandr-konovalov @DominikBernhardt @wucas @PaulaHaehndel