Give more helpful warning when using tabs in continuations #3375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJefferson
force-pushed
the
test-fix
branch
from
0a0959f
to
bba65fc
Compare
wucas
added
kind: bug
fingolfin
reviewed
Mar 24, 2019
Codecov Report
@@ Coverage Diff @@
## master #3375 +/- ##
==========================================
+ Coverage 85.14% 85.33% +0.19%
==========================================
Files 697 696 -1
Lines 344069 342430 -1639
==========================================
- Hits 292941 292208 -733
+ Misses 51128 50222 -906
|
This rejects continuations using 'tab' inside tests. They can be confusing for users because GAP does not treat them as continuations, but instead a line of output. They are rejected, rather than treated as continuations, because we do not want different parts of GAP to handle continuations differently, or really start changing the definition of something so fundamental. This does break any tests which start an output line with '>\t', but no such tests seem to exist and would be easily confused with a continuation.
ChrisJefferson
force-pushed
the
test-fix
branch
from
e6b3002
to
7af058a
Compare
|
All cleaned up. Also, did a quick cleanup using |
markusbaumeister
added
the
release notes: to be added
DominikBernhardt
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rejects continuations using 'tab' inside tests. They can
be confusing for users because GAP does not treat them as
continuations, but instead a line of output.
They are rejected, rather than treated as continuations, because
we do not want different parts of GAP to handle continuations
differently, or really start changing the definition of something
so fundamental.
This does break any tests which start an output line with '>\t',
but no such tests seem to exist and would be easily confused with
a continuation.
Fixes #3068 (by giving a nice error) while hopefully not breaking any tests (unlike my previous attempt at fixing this, which broke Browse).