Add ShowUsedInfoClasses #3387
Merged
Add ShowUsedInfoClasses #3387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJefferson
force-pushed
the
info-info
branch
2 times, most recently
from
310eec5
to
3e63c74
Compare
Codecov Report
@@ Coverage Diff @@
## master #3387 +/- ##
==========================================
+ Coverage 77.51% 85.16% +7.64%
==========================================
Files 691 698 +7
Lines 340399 344098 +3699
==========================================
+ Hits 263875 293037 +29162
+ Misses 76524 51061 -25463
|
ChrisJefferson
force-pushed
the
info-info
branch
from
3e63c74
to
d33ef0e
Compare
DominikBernhardt
added
kind: enhancement
ChrisJefferson
force-pushed
the
info-info
branch
from
d33ef0e
to
e0e94f7
Compare
|
Hopefully all issues fixed |
|
Wait, the naming is inconsistent. I'm going to standardise on ShowUsedInfoClasses. |
ChrisJefferson
force-pushed
the
info-info
branch
from
e0e94f7
to
f942d05
Compare
fingolfin
reviewed
Apr 6, 2019
wilfwilson
added
the
release notes: to be added
wilfwilson
reviewed
Apr 6, 2019
There was a problem hiding this comment.
I had briefly looked at this before, when I didn't have time to write comments, but my comments would have been about the documentation. @fingolfin has suggested pretty much everything that I was going to suggest, leaving me with not much to do.
ChrisJefferson
force-pushed
the
info-info
branch
from
77cd262
to
55db386
Compare
wilfwilson
reviewed
Apr 7, 2019
ChrisJefferson
force-pushed
the
info-info
branch
from
55db386
to
dfb8333
Compare
wilfwilson
approved these changes
Apr 7, 2019
ChrisJefferson
force-pushed
the
info-info
branch
from
5f0c032
to
46b7931
Compare
fingolfin
reviewed
Apr 8, 2019
src/info.c
Outdated
| STATE(ShowUsedInfoClassesActive) = 0; | ||
| } | ||
| else { | ||
| ErrorMayQuit("<setting> should be true or false", 0, 0); |
There was a problem hiding this comment.
Could also use RequireTrueOrFalse for a consistent error message
There was a problem hiding this comment.
... and then a test of this error handling would also be nice, for full coverage.
fingolfin
reviewed
Apr 8, 2019
fingolfin
approved these changes
Apr 8, 2019
lib/info.gd
Outdated
| @@ -131,6 +131,7 @@ DeclareOperation("InfoLevel", [IsInfoClass]); | |||
| DeclareGlobalFunction("SetInfoHandler"); | |||
| DeclareGlobalFunction("DefaultInfoHandler"); | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Why is this empty line inserted in a file that otherwise is not modified at all in this PR?
src/info.c
Outdated
| STATE(ShowUsedInfoClassesActive) = 0; | ||
| } | ||
| else { | ||
| ErrorMayQuit("<setting> should be true or false", 0, 0); |
There was a problem hiding this comment.
... and then a test of this error handling would also be nice, for full coverage.
ChrisJefferson
force-pushed
the
info-info
branch
from
46b7931
to
436ca5c
Compare
|
Thanks for feedback, (hopefully) all issues fixed. |
DominikBernhardt
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3379
This is two commits -- the first pulls some Info stuff that was probably in the wrong place into it's own file, the second then adds ShowUsedInfoClasses (as described in the docs, and #3379).