-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary fix for the Julia GC. #3412
Merged
fingolfin
merged 4 commits into
gap-system:master
from
rbehrends:julia-gc-validate-strict
Apr 25, 2019
Merged
Temporary fix for the Julia GC. #3412
fingolfin
merged 4 commits into
gap-system:master
from
rbehrends:julia-gc-validate-strict
Apr 25, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
requested changes
Apr 15, 2019
f14e858
to
379b538
Compare
Codecov Report
@@ Coverage Diff @@
## master #3412 +/- ##
==========================================
+ Coverage 85.4% 85.41% +0.01%
==========================================
Files 698 697 -1
Lines 344337 342390 -1947
==========================================
- Hits 294097 292469 -1628
+ Misses 50240 49921 -319
|
379b538
to
65c4bd4
Compare
fingolfin
requested changes
Apr 16, 2019
65c4bd4
to
2b22eea
Compare
fingolfin
reviewed
Apr 16, 2019
2b22eea
to
511e667
Compare
fingolfin
reviewed
Apr 18, 2019
sebasguts
reviewed
Apr 19, 2019
eabd1b2
to
9822c00
Compare
fingolfin
reviewed
Apr 23, 2019
16169ca
to
56750a5
Compare
fingolfin
reviewed
Apr 23, 2019
efbb767
to
6ab4559
Compare
This addresses a problem where the Julia GC during a partial sweep frees some, but not all objects of an unreachable data structure. If an address to a remaining object of such a data structure is still randomly hit during conservative stack scanning, it may erroneously try to mark the deallocated objects, too. This temporary fix works by validating each pointer before it is marked. Because this is potentially expensive, the eventual solution should fix the root cause, which is conservative stack scanning resurrecting pointers to dead objects that have been freed during a partial collection.
6ab4559
to
49f65b4
Compare
fingolfin
approved these changes
Apr 25, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-to-4.10-DONE
kind: bug: crash
Issues describing bugs that cause GAP to crash, and PRs fixing them (used for release notes)
kind: bug
Issues describing general bugs, and PRs fixing them
release notes: added
PRs introducing changes that have since been mentioned in the release notes
topic: julia
Julia GC integration and related matters
topic: kernel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a problem where the Julia GC during a partial sweep frees
some, but not all objects of an unreachable data structure. If an
address to a remaining object of such a data structure is still randomly
hit during conservative stack scanning, it may erroneously try to mark
the deallocated objects, too.
This temporary fix works by validating each pointer before it is marked.
Because this is potentially expensive, the eventual solution should fix
the root cause, which is conservative stack scanning resurrecting
pointers to dead objects that have been freed during a partial
collection.