Turn NameFunction into an attribute so that custom function objects can implement support for it #3430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it was an operation that kind of acted like an attribute, but not quite. Now one may use HasNameFunction, and also provide custom methods for it for custom function types.
fingolfin
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3430 +/- ##
=========================================
- Coverage 84.97% 84.18% -0.8%
=========================================
Files 699 698 -1
Lines 346081 345970 -111
=========================================
- Hits 294087 291254 -2833
- Misses 51994 54716 +2722
|
fingolfin
added
the
kind: enhancement
fingolfin
changed the title
|
I just updated this PR, cleaning it up a bit, and adding some tests to ensure that the kernel attribute works as intended. |
ChrisJefferson
approved these changes
May 4, 2019
fingolfin
changed the title
fingolfin
added
the
release notes: to be added
DominikBernhardt
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential alternative to PR #3420. It needs some polishing and tests, but at least for some quick tests, seems to work reasonably well. I won't have time to work more on it for now, so if somebody else wants to continue with this, feel free to do so.
UPDATE: I have now improved this PR, it should be ready for merging.