Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibGAP API: Add GAP_AssignGlobalVariable and GAP_CanAssignGlobalVariable #3438

Merged
merged 1 commit into from
May 11, 2019

Conversation

sebasguts
Copy link
Member

@sebasguts sebasguts commented May 6, 2019

Description

Adds GAP_AssignGlobalVariable and GAP_IsNameOfWritableGlobalVariable to the libgap API, to assign a global variable to a value and check if a name belongs to a writable gvar.

Text for release notes

LibGAP API: GAP_AssignGlobalVariable and GAP_IsNameOfWritableGlobalVariable added

Further details

If necessary, please provide further details here.

Checklist for pull request reviewers

  • proper formatting

If your code contains kernel C code, run clang-format on it; the
simplest way is to use git clang-format, e.g. like this (don't
forget to commit the resulting changes):

git clang-format $(git merge-base master)
  • usage of relevant labels

    1. either release notes: not needed or release notes: to be added
    2. at least one of the labels bug or enhancement or new feature
    3. for changes meant to be backported to stable-4.X add the backport-to-4.X label
    4. consider adding any of the labels build system, documentation, kernel, library, tests
  • runnable tests

  • adequate pull request title

  • well formulated text for release notes

  • relevant documentation updates

  • sensible comments in the code

@sebasguts sebasguts requested a review from fingolfin May 6, 2019 08:54
src/libgap-api.c Outdated Show resolved Hide resolved
src/libgap-api.h Outdated Show resolved Hide resolved
src/libgap-api.h Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented May 6, 2019

Coverage Status

Coverage decreased (-0.001%) to 85.152% when pulling 61fc5b0 on sebasguts:sg/libgap-gvars into 84cd55e on gap-system:master.

@fingolfin fingolfin added release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes topic: kernel topic: libgap things related to libgap labels May 6, 2019
@fingolfin fingolfin changed the title Added GAP_AssignGlobalVariable to libgap-api LibGAP API: GAP_AssignGlobalVariable added May 6, 2019
@sebasguts sebasguts force-pushed the sg/libgap-gvars branch 2 times, most recently from 7682799 to 8a4817e Compare May 6, 2019 14:43
src/libgap-api.h Outdated Show resolved Hide resolved
src/libgap-api.h Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #3438 into master will decrease coverage by 0.26%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3438      +/-   ##
==========================================
- Coverage   85.34%   85.08%   -0.27%     
==========================================
  Files         699      698       -1     
  Lines      346092   346096       +4     
==========================================
- Hits       295374   294468     -906     
- Misses      50718    51628     +910
Impacted Files Coverage Δ
src/libgap-api.c 1.16% <0%> (-62.1%) ⬇️
src/compiler.c 66.99% <0%> (-21.71%) ⬇️
src/vars.c 81.58% <0%> (-12.49%) ⬇️
src/error.c 77.56% <0%> (-10.65%) ⬇️
src/stats.c 85.94% <0%> (-9.24%) ⬇️
src/exprs.h 93.75% <0%> (-6.25%) ⬇️
src/exprs.c 93.16% <0%> (-4.75%) ⬇️
src/intrprtr.c 95.3% <0%> (-4.54%) ⬇️
src/funcs.c 96.36% <0%> (-2.43%) ⬇️
... and 12 more

src/libgap-api.h Outdated Show resolved Hide resolved
src/libgap-api.h Outdated Show resolved Hide resolved
@fingolfin fingolfin force-pushed the sg/libgap-gvars branch 2 times, most recently from f98810c to 5fec327 Compare May 10, 2019 11:35
@fingolfin fingolfin changed the title LibGAP API: GAP_AssignGlobalVariable added LibGAP API: Add GAP_AssignGlobalVariable and GAP_CanAssignGlobalVariable May 11, 2019
@fingolfin fingolfin merged commit ce3cec5 into gap-system:master May 11, 2019
@sebasguts
Copy link
Member Author

Thank you for updating and merging :)

@fingolfin fingolfin added this to the GAP 4.10.2 milestone Jun 13, 2019
@olexandr-konovalov olexandr-konovalov added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-4.10-DONE release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel topic: libgap things related to libgap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants