Performance improvements #3451
Merged
Performance improvements #3451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulpke
added
kind: enhancement
Codecov Report
@@ Coverage Diff @@
## master #3451 +/- ##
==========================================
+ Coverage 85.34% 85.38% +0.04%
==========================================
Files 699 699
Lines 346504 346767 +263
==========================================
+ Hits 295733 296099 +366
+ Misses 50771 50668 -103
|
hulpke
removed
the
do not comment yet
hulpke
removed
the
do not merge
hulpke
force-pushed
the
additions
branch
7 times, most recently
from
04fda8b
to
52df9bc
Compare
Also RepresentativeAction for OnTuplesSets of points.
- ContainedConjugates uses perm. group orbits - Double cosets considers subgroups by increasing index - Move (same) calculation outside inner loop Fix assumption about generators of fphom Code wrongly assumed that isomorphism fo fp was always to free generators. This is not guaranteed (but so far always held, so was not spotted).
Use representation theory to predict which subgroup, w/o initial rewriting. Directly write down permrep for semidirect product. Moved twocohom.tst to teststandard, as it seems to be better place to reduce load on travis Added utility function to iterate through subgroups. Increasing index, initially don't attempt to compute whole lattice. Not in manual as it could make conjugates, ordering not perfect
Avoid infinite loop in bad cases of NHBNS. Allow slightly more generators in initial check.
Test for running, n ot concrete output. Also change one assertion level higher so that it is not triggered by the (arbitrarily chosen level of) the automatic tests. (This is safer than ad-hoc quickly changing complicated but stable code.) This is a "be nice" assertion (that was never intended for automated tests), not a must have. This resolves gap-system#3464
fingolfin
approved these changes
Jun 4, 2019
|
REMINDER - to all PR authors and reviewers: if a PR adds tests to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improvements that mostly relate to computing double cosets, in particular in symmetric groups, and to permutation representations of extensions:
testextra/grpperm.tstin master branch #3464Text for release notes
Performance of double coset calculations, in particular in symmetric and alternating groups, has been improved.