Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CharacteristicSubgroups to the reference manual #3529

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

fingolfin
Copy link
Member

Also fix typo in an example on its manpage, and add another example to it and
to NormalSubgroups which clearly shows the difference.

@hulpke added CharacteristicSubgroups, so it would be good to know if he is comfortable with making this attribute "official".

@fingolfin fingolfin added topic: documentation Issues and PRs related to documentation topic: library release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Jun 27, 2019
@fingolfin fingolfin requested a review from hulpke June 27, 2019 11:41
Copy link
Contributor

@hulpke hulpke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these are better examples

Also fix typo in an example on its manpage, and add another example to it and
to NormalSubgroups which clearly shows the difference.
@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

Merging #3529 into master will decrease coverage by 5.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3529      +/-   ##
==========================================
- Coverage   85.46%   80.03%   -5.44%     
==========================================
  Files         696      692       -4     
  Lines      344989   342192    -2797     
==========================================
- Hits       294845   273872   -20973     
- Misses      50144    68320   +18176
Impacted Files Coverage Δ
lib/grp.gd 100% <ø> (ø) ⬆️
lib/ctbllatt.gi 4.94% <0%> (-79.62%) ⬇️
lib/proto.gi 13.4% <0%> (-71.14%) ⬇️
src/libgap-api.c 1.16% <0%> (-63.38%) ⬇️
lib/schursym.gi 10.6% <0%> (-58.51%) ⬇️
src/saveload.c 10.05% <0%> (-58.16%) ⬇️
lib/ctblpope.gi 19.61% <0%> (-57.87%) ⬇️
lib/addgphom.gi 8.69% <0%> (-56.53%) ⬇️
lib/ctblmaps.gi 20.68% <0%> (-55.8%) ⬇️
lib/teaching.g 33.26% <0%> (-54.82%) ⬇️
... and 198 more

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0003%) to 85.289% when pulling 3658990 on fingolfin:mh/CharacteristicSubgroups into 384ccc4 on gap-system:master.

@fingolfin fingolfin merged commit 99d18ff into gap-system:master Jun 28, 2019
@fingolfin fingolfin deleted the mh/CharacteristicSubgroups branch June 28, 2019 15:11
@DominikBernhardt DominikBernhardt added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Aug 20, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes topic: documentation Issues and PRs related to documentation topic: library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants