Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new kernel operations ELM_MAT, ASS_MAT #3551

Merged
merged 3 commits into from
Jul 12, 2019
Merged

Add new kernel operations ELM_MAT, ASS_MAT #3551

merged 3 commits into from
Jul 12, 2019

Commits on Jul 11, 2019

  1. Add new kernel operations ELM_MAT, ASS_MAT 

    The kernel functions with the same name now delegate to these operations
instead of ELM_LIST, ASS_LIST.

Also turned MatElm, SetMatElm into synonyms for ELM_MAT, ASS_MAT.

Code which uses MatrixObj for a long time and thus installed methods for
MatElm, SetMatElm will thus work unchanged. Code which adapted to the
recommendation in GAP 4.10 and thus instead installed methods for ELM_LIST,
ASS_LIST with 3 resp. 4 arguments now should be adapted to (again) install
methods for MatElm, SetMatElm for maximal compatibility. To ensure this code
works after this change, though, we provide low ranked fallback methods in
ELM_MAT, ASS_MAT which delegate to ELM_LIST, ASS_LIST. At the same time, we
remove the low-ranged delegations from ELM_LIST, ASS_LIST to MatElm,
SetMatElm to ensure we don't end up delegating back and forth endlessly.
    @fingolfin
    fingolfin committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    dbe0374 View commit details
    Browse the repository at this point in the history

  2. Fix typo in method description: MatFE -> MatFFE

    @fingolfin
    fingolfin committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    4d6e1b4 View commit details
    Browse the repository at this point in the history

  3. Change some method descriptions to start with "for" 

    ... and not "For" -- this matches the style in the rest of the library.
    @fingolfin
    fingolfin committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    ea1a88c View commit details
    Browse the repository at this point in the history