Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add systematic tests for euclidean ring properties; fix/implement those for Integers mod n #3604

Merged
merged 5 commits into from
Aug 19, 2019
Merged

Add systematic tests for euclidean ring properties; fix/implement those for Integers mod n #3604

merged 5 commits into from
Aug 19, 2019

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Aug 18, 2019 •
edited by wilfwilson
Loading

Resolves #3511.

@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: library labels Aug 18, 2019
@coveralls
Copy link

coveralls commented Aug 19, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 84.299% when pulling 9ded208 on fingolfin:mh/zmodnz-euclidean into 28d29fa on gap-system:master.

wilfwilson
wilfwilson reviewed Aug 19, 2019
View reviewed changes
lib/zmodnz.gi Outdated Show resolved Hide resolved
@wilfwilson
Copy link
Member

I took the liberty of updating the PR description to say that this resolves #3511. Please correct if that's not right!

@fingolfin
Copy link
Member Author

@wilfwilson thanks, I forgot about that issue!

@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #3604 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3604      +/-   ##
==========================================
+ Coverage   84.55%   84.55%   +<.01%     
==========================================
  Files         698      698              
  Lines      345274   345294      +20     
==========================================
+ Hits       291931   291959      +28     
+ Misses      53343    53335       -8
Impacted Files Coverage Δ
lib/zmodnz.gd 100% <100%> (ø) ⬆️
lib/zmodnz.gi 98.08% <100%> (+0.05%) ⬆️
lib/field.gi 74.04% <100%> (+0.88%) ⬆️
hpcgap/lib/hpc/stdtasks.g 72.18% <0%> (-0.21%) ⬇️
lib/ring.gi 75.05% <0%> (+0.23%) ⬆️
lib/rational.gi 77.1% <0%> (+0.4%) ⬆️

@fingolfin fingolfin merged commit 25b5167 into gap-system:master Aug 19, 2019
@fingolfin fingolfin deleted the mh/zmodnz-euclidean branch August 19, 2019 10:06
@DominikBernhardt DominikBernhardt added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Aug 20, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominikBernhardt DominikBernhardt DominikBernhardt approved these changes

@wilfwilson wilfwilson wilfwilson approved these changes

@wucas wucas Awaiting requested review from wucas

@AnnaKDS AnnaKDS Awaiting requested review from AnnaKDS

Assignees
No one assigned
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes topic: library
Projects
None yet
Milestone
GAP 4.11.0
Development

Successfully merging this pull request may close these issues.

Implement EuclideanDegree and QuotientRemainder for Z/nZ
5 participants
@fingolfin @coveralls @wilfwilson @DominikBernhardt @olexandr-konovalov