Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid use of / on ZmodnZObjs (e.g. dividing a unit by a zero divisor) produces an error, instead of returning fail #3610

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

fingolfin
Copy link
Member

If you want fail, use Quotient, which was made for that.

@fingolfin fingolfin added the gapsingular2019 Issues and PRs that arose at https://opendreamkit.org/meetings/2019-04-02-GAPSingularMeeting label Aug 20, 2019
@DominikBernhardt
Copy link
Contributor

@fingolfin I think you forgot to adjust a few tests as they still expect fail as an output.

@fingolfin fingolfin added release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes topic: library labels Aug 21, 2019
@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #3610 into master will decrease coverage by 9.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3610      +/-   ##
==========================================
- Coverage   84.64%    75.6%   -9.05%     
==========================================
  Files         698      646      -52     
  Lines      345549   296727   -48822     
==========================================
- Hits       292482   224328   -68154     
- Misses      53067    72399   +19332
Impacted Files Coverage Δ
lib/zmodnz.gi 78.76% <0%> (-19.43%) ⬇️
src/fibhash.h 0% <0%> (-100%) ⬇️
src/syntaxtree.c 5.44% <0%> (-90.72%) ⬇️
lib/meatauto.gi 5.99% <0%> (-89.32%) ⬇️
lib/nilpquot.gi 11.11% <0%> (-88.89%) ⬇️
src/modules.h 16.66% <0%> (-83.34%) ⬇️
lib/helpt2t.gi 0.23% <0%> (-83.14%) ⬇️
src/dteval.c 3.3% <0%> (-80.12%) ⬇️
src/objset.c 8.13% <0%> (-76.74%) ⬇️
lib/dt.g 7.75% <0%> (-72.2%) ⬇️
... and 422 more

@coveralls
Copy link

coveralls commented Aug 21, 2019

Coverage Status

Coverage remained the same at 84.395% when pulling 9101aa9 on fingolfin:mh/zmodnz-strict-div into 659250f on gap-system:master.

@wilfwilson wilfwilson merged commit 963a14d into gap-system:master Aug 22, 2019
@fingolfin fingolfin deleted the mh/zmodnz-strict-div branch August 22, 2019 22:15
@dimpase dimpase added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 4, 2020
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gapsingular2019 Issues and PRs that arose at https://opendreamkit.org/meetings/2019-04-02-GAPSingularMeeting release notes: added PRs introducing changes that have since been mentioned in the release notes topic: library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants