Make TmpNameAllArchs obsolete by enhancing TmpName
#3702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
os: windows
fingolfin
requested review from
ChrisJefferson,
olexandr-konovalov,
stevelinton and
hulpke
|
windows vs cygwin names is a pain. If you pass cygwin filenames to window executables, they will get confused, while cygwin executables will accept windows paths, so there is an argument windows paths are better. But we are inconsistent with what types of paths we give out all over the place. |
|
@ChrisJefferson I am of course happy to use a On the long run, we really need better Windows testing, too. If "somebody" could figure out how to setup package tests similar to https://travis-ci.org/gap-infra/gap-docker-pkg-tests-master but using Windows, that'd be awesome (regardless of whether it is based on AppVeyor (which we already use for Windows testing, but which I find otherwise rather clunky to use), Travis for Windows, Azure Pipelines, GitHub Actions, CircleCI, or whatever.... They all offer free Windows CI for open source projects in one way or another. |
|
I guess issue #2023 is related... |
hulpke
approved these changes
Oct 18, 2019
|
On I will continue with the rest of tests. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
And the last one. |
|
|
This was referenced Jan 3, 2020
fingolfin
changed the title
fingolfin
changed the title
Essentially, we move the added logic from TmpNameAllArchs to TmpName, but slightly tweaked, so that it matches the behavior of TmpDirectory. Also merge some Windows specific code in the GAP function `DirectoryTemporary` into the kernel function `FuncTmpDirectory`
|
Since parts of this PR were merged, I've now rebased it down to a single commit, which makes it much easier to see what is going on. I also changed it to not switch to using the controversial
So, I now went the opposite direction, and change |
|
I think before this merged I should test this under Windows properly, starting from |
wilfwilson
approved these changes
Feb 5, 2020
There was a problem hiding this comment.
I think this looks fine, but then again I haven’t tested it with Windows. I look forward to the results of @alex-konovalov’s Windows testing.
olexandr-konovalov
approved these changes
Feb 12, 2020
PaulaHaehndel
added
the
release notes: added
fingolfin
changed the title
TmpNameAllArchs obsolete by enhancing TmpName
fingolfin
added
the
kind: removal or deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in 2011, a new library function
TmpNameAllArchswas added which wraps the kernel functionTmpNameand adds some Windows specific sauce to it. This PR enhancesTmpNameso thatTmpNameAllArchscan be turned into a simple synonym forTmpName. It does so by aligning the code ofFuncTmpNameandFuncTmpDirectorymore closely. (They still differ in that the latter honors the theTMPDIRenv var, the former does not; we might want to change that, but I didn't want to make too big a change in one go.There is another difference between the old and new code: the old used
C:/WINDOWS/Temp/, the new uses/cygdrive/c/WINDOWS/Temp/. I hope that doesn't matter or even is an improvement, but it would be really good if somebody with Windows access could verify that (beyond what little the tests in our test suite do).Resolves #3328
The other change in this PR is the removal of the library function
ShortFileNameWindowswhich @hulpke added in 2009 but which hasn't ever been used by GAP or any package, as far as I can tell. It's also undocumented, and it seems not so useful to access 8.3 filenames these days. But perhaps I am mistaken, and there are usecases (in particular, I have no idea what the motivation for adding it back then was).