Adjust TestPackage to return info about test result #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... at least where possible; the value `true` indicates success, `false` means that tests were run but failed, and `fail` that there was an error, e.g. no tests were found or it was not possible tor run them.
fingolfin
force-pushed
the
mh/TestPackage
branch
from
2555b88
to
2a075af
Compare
ChrisJefferson
approved these changes
Oct 21, 2019
olexandr-konovalov
approved these changes
Oct 22, 2019
There was a problem hiding this comment.
Looks good, then we may drop TestOnePackage from https://github.com/gap-infra/gap-docker-pkg-tests-master-devel/blob/master/ci.g. Agree to backport to 4.11.
|
Backported to |
fingolfin
added
the
release notes: to be added
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... at least where possible; the value
trueindicates success,falsemeansthat tests were run but failed, and
failthat there was an error, e.g. notests were found or it was not possible tor run them.
This contains code which is contained in several repositories under https://github.com/gap-infra/ such as here: https://github.com/gap-infra/gap-docker-pkg-tests-master-devel/blob/master/ci.g
We could backport this to stable-4.11 -- or are there concerns about that?