Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue with error reporting in parallel threads #3759

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Fix an issue with error reporting in parallel threads #3759

merged 1 commit into from
Nov 25, 2019

Conversation

rbehrends
Copy link
Contributor

Without making the ERROR_OUTPUT constant immutable in lib/error.g, it belongs to the main thread and cannot be used for error reporting in concurrent threads.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.0e-05%) to 84.674% when pulling 8305416 on rbehrends:hpcgap-error-report into 8a27b12 on gap-system:master.

@ChrisJefferson ChrisJefferson merged commit b5f7418 into gap-system:master Nov 25, 2019
@fingolfin fingolfin deleted the hpcgap-error-report branch November 26, 2019 12:27
@fingolfin
Copy link
Member

Ah, I didn't see this yesterday, otherwise I would have asked that the tests this is supposed to fix are re-enabled... I'll submit another PR for that, then.

@PaulaHaehndel PaulaHaehndel self-assigned this Feb 17, 2021
@PaulaHaehndel PaulaHaehndel changed the title Fix an issue with error reporting in parallel threads. Fix an issue with error reporting in parallel threads Feb 17, 2021
@PaulaHaehndel PaulaHaehndel added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Feb 17, 2021
@PaulaHaehndel PaulaHaehndel removed their assignment Feb 17, 2021
@olexandr-konovalov olexandr-konovalov mentioned this pull request Mar 23, 2021
Merged
@fingolfin fingolfin added the topic: HPC-GAP Issues and PRs related to HPC-GAP label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisJefferson ChrisJefferson ChrisJefferson approved these changes

Assignees
No one assigned
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes topic: HPC-GAP Issues and PRs related to HPC-GAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rbehrends @coveralls @fingolfin @ChrisJefferson @PaulaHaehndel