Fix a crash when using a constant global variable (created via MakeConstantGlobal, such as IsHPCGAP) as index variable of a for loop
#3808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reader ("parser") did not sufficiently restrict the kind of expression
permitted as index variable in `for` loops. So one could enter e.g. this:
for x[1] in [1] do od;
The result was a nonsensical error message. Worse, one could specify a
"constant" variable, which caused a segfault; e.g.
for IsHPCGAP in [1] do od;
fingolfin
added
kind: bug
Since we now have the type of the index variable readily available in ReadFor, we can move the calls to Push/PopGlobalForLoopVariable from the coder to the reader, where they arguably always belonged.
fingolfin
force-pushed
the
mh/fix-for-loop-var
branch
from
31fecda
to
5024072
Compare
DominikBernhardt
approved these changes
Dec 31, 2019
ChrisJefferson
approved these changes
Dec 31, 2019
ThomasBreuer
added
release notes: added
fingolfin
changed the title
MakeConstantGlobal, such as IsHPCGAP) as index variable of a for loop
fingolfin
added
the
release notes: use title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reader ("parser") did not sufficiently restrict the kind of expression
permitted as index variable in
forloops. So one could enter e.g. this:The result was a nonsensical error message. Worse, one could specify a
"constant" variable, which caused a segfault; e.g.
Text for release notes
Fixed a crash when using a constant global variable (created via
MakeConstantGlobal) as index variable of a for loop.