Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add InnerAutomorphismGroup attribute for groups #3914

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Add InnerAutomorphismGroup attribute for groups #3914

merged 1 commit into from
Mar 6, 2020

Conversation

fingolfin
Copy link
Member

If the automorphism group is known, calls InnerAutomorphismsAutomorphismGroup;
otherwise creates the InnerAutomorphismGroup from scratch.

I suspect that there is a reason InnerAutomorphismGroup does not exist right now (i.e. this PR might be too naive); hopefully @hulpke knows about that. So please don't merge this before he had a chance to comment.

@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: library release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Mar 5, 2020
@fingolfin fingolfin requested a review from hulpke March 5, 2020 13:22
hulpke
hulpke reviewed Mar 5, 2020
View reviewed changes
lib/morpheus.gi Outdated Show resolved Hide resolved
@fingolfin
Add InnerAutomorphismGroup for groups
106272e 
If the automorphism group is known, calls InnerAutomorphismsAutomorphismGroup;
otherwise creates the InnerAutomorphismGroup from scratch.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0004%) to 84.779% when pulling 106272e on fingolfin:mh/InnerAutomorphismGroup into 84735fd on gap-system:master.

@fingolfin fingolfin merged commit 89dff55 into gap-system:master Mar 6, 2020
@fingolfin fingolfin deleted the mh/InnerAutomorphismGroup branch March 6, 2020 09:57
@danielrademacher danielrademacher self-assigned this Feb 16, 2021
@danielrademacher danielrademacher changed the title Add InnerAutomorphismGroup for groups Added the attribute "InnerAutomorphismGroup" for groups Feb 16, 2021
@danielrademacher danielrademacher added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 16, 2021
@danielrademacher danielrademacher changed the title Added the attribute "InnerAutomorphismGroup" for groups Added the attribute 'InnerAutomorphismGroup' for groups Feb 16, 2021
@olexandr-konovalov olexandr-konovalov mentioned this pull request Feb 19, 2021
Closed
@olexandr-konovalov olexandr-konovalov mentioned this pull request Mar 23, 2021
Merged
@fingolfin fingolfin changed the title Added the attribute 'InnerAutomorphismGroup' for groups Add InnerAutomorphismGroup attribute for groups Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hulpke hulpke hulpke approved these changes

Assignees

@danielrademacher danielrademacher

Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements kind: new feature release notes: added PRs introducing changes that have since been mentioned in the release notes topic: library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fingolfin @coveralls @hulpke @danielrademacher