Refine the logic for scanning Julia stacks #4058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbehrends
force-pushed
the
julia-gc-stackscan
branch
from
99de293
to
d1096e4
Compare
fingolfin
reviewed
Jun 24, 2020
fingolfin
reviewed
Jun 24, 2020
fingolfin
reviewed
Jun 24, 2020
fingolfin
added
topic: julia
fingolfin
reviewed
Jun 26, 2020
src/julia_gc.c
Outdated
| if (task->copy_stack) { | ||
| // task->copy_stack, if not zero or one, is an upper bound for the | ||
| // size of the stack. | ||
| if (task->copy_stack > 1) { |
There was a problem hiding this comment.
I am not sure this is quite right now -- the value task->copy_stack == 1 should probably still be treated separately? I think it can only occur for "fresh" tasks which don't have a stack allocation yet; so I assume we could just do if (task->copy_stack ==1) return; or so?
There was a problem hiding this comment.
Hmm, I'll go and have a look at that.
There was a problem hiding this comment.
So, task->copy_stack == 1 implies task->bufsz == 0. This means that the logic is accidentally correct, but the comment would have to change. But I think that making control flow more explicit by aborting stack scanning for task->copy_stack == 1 is much clearer, so I'll go with that.
rbehrends
force-pushed
the
julia-gc-stackscan
branch
from
24f577a
to
d298d2f
Compare
fingolfin
approved these changes
Jun 30, 2020
rbehrends
force-pushed
the
julia-gc-stackscan
branch
from
40b7ba8
to
5c431b5
Compare
|
Done in 74cfb2a |
PaulaHaehndel
added
the
release notes: added
PaulaHaehndel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes how we handle scanning the root task of the main thread. It also improves the comments that explain stack scanning logic.