Add GAP_MarkBag, GAP_CollectBags, a minimal interface to the garbage collector
#4215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ystem#3030 these are probably the minimal interfaces that need to be exposed, and are compatible with all current GC implementations. As suggested at gap-system#3030 (comment) GAP_CollectBags only takes a <full> argument, but not <size>
fingolfin
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
Looks good to me but it'd be nice if @ChrisJefferson also had a look
fingolfin
approved these changes
Jan 20, 2021
There was a problem hiding this comment.
I took the liberty of applying some tweaks, to make the tests pass and to address some minor nitpicks of mine. Hope that was OK, of course we can still revise!
Still would like a second opinion by @ChrisJefferson . But in general this seems to me to be OK to merge
|
This is fine to merge with me. I point out the existence of InitGlobalBag, it might be places where you are using MarkBag you could be using InitGlobalBag if you only set some things up once. I wouldn't bother adding a wrapper for it until someone wants it. |
ThomasBreuer
changed the title
libgap API: Expose a minimal interface to the garbage collector, via GAP_MarkBag, GAP_CollectBags
ThomasBreuer
added
the
release notes: added
fingolfin
changed the title
libgap API: Expose a minimal interface to the garbage collector, via GAP_MarkBag, GAP_CollectBagsGAP_MarkBag, GAP_CollectBags, a minimal interface to the garbage collector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add libgap interfaces to the garbage collector. As discussed in #3030
these are probably the minimal interfaces that need to be exposed, and
are compatible with all current GC implementations.
As suggested at #3030 (comment)
GAP_CollectBags only takes a
fullargument, but notsize.Copy-editing may be needed on the documentation the header.