Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cite to again properly compute the year in which GAP was released #4317

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

ThomasBreuer
Copy link
Contributor

The format of GAPInfo.Date has been changed recently.
Cite had not been adjusted to this change,
thus the number of the day got inserted instead of the year.

The format of `GAPInfo.Date` has been changed recently.
`Cite` had not been adjusted to this change,
thus the number of the day got inserted instead of the year.
@ThomasBreuer ThomasBreuer added kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Mar 8, 2021
@fingolfin
Copy link
Member

Does this affect 4.11.1 or master (it doesn't show in the dev build for me, as then the date is set to today anyway)

@ThomasBreuer
Copy link
Contributor Author

@fingolfin The problem affects up to now only GAP 4.11.1:

gap> Cite();
Please use one of the following samples
to cite GAP version from this installation

Text:

[GAP]  GAP  –  Groups,  Algorithms, and Programming, Version 4.11.1, The GAP
Group (02), https://www.gap-system.org.
[...]

It was not yet present in GAP 4.11.0:

gap> Cite();
Please use one of the following samples
to cite GAP version from this installation

Text:

[GAP]  GAP  –  Groups,  Algorithms, and Programming, Version 4.11.0, The GAP
Group (2020), https://www.gap-system.org.
[...]

And it cannot be observed in the dev version, due to a special handling in the code (which makes it difficult to find it in advance):

gap> Cite();
Please use one of the following samples
to cite GAP version from this installation

Text:

[GAP]  GAP  –  Groups, Algorithms, and Programming, Version 4.12dev, The GAP
Group, https://www.gap-system.org.
[...]

@fingolfin
Copy link
Member

OK thanks for the clarification; so we also need to backport it to stable-4.11 (just in case we want to make a 4.11.2)

@fingolfin fingolfin added backport-to-4.11 kind: bug Issues describing general bugs, and PRs fixing them labels Mar 11, 2021
@fingolfin fingolfin merged commit c7a0c6e into gap-system:master Mar 11, 2021
@ThomasBreuer ThomasBreuer deleted the TB_Cite branch March 11, 2021 12:30
@fingolfin fingolfin changed the title fixed Cite(); it had used the number of the day, not the year Fix Cite to again properly compute the year in which GAP was released Aug 17, 2022
@fingolfin fingolfin removed backport-to-4.11 kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Issues describing general bugs, and PRs fixing them release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants