Fix computation of all maximal subgroups (under specific circumstances, an incomplete list was returned) #4396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of storing one attribute and a flag that indicates that it might be only a partial list, store potentially multiple lists and the restrictions under which they were computed. This avoids a qualified result sneaking in as true. This fixes gap-system#4395
hulpke
added
kind: bug: wrong result
wilfwilson
approved these changes
Apr 14, 2021
fingolfin
approved these changes
Apr 14, 2021
fingolfin
changed the title
fingolfin
added
release notes: use title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of storing one attribute and a flag that indicates that it might be
only a partial list, store potentially multiple lists and the restrictions
under which they were computed. This avoids a qualified result sneaking in
as true.
This fixes #4395
The correction unfortunately goes across a larger number of files, though most changes are tiny.