Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line option --print-gaproot #4465

Merged
merged 2 commits into from
May 11, 2021

Conversation

ThomasBreuer
Copy link
Contributor

Note that the list of command line options in the GAP Reference Manual (Section "Command Line Options") does not contain several of the options that have been added recently.
More precisely, this list does not mention options with "long form" that start with --, and does not list any of these options.
Should we extend the list in the manual, or should we perhaps better refer to the list printed by the -h (or --help) option?

resolves #4448

Note that the list of command line options in the GAP Reference Manual
(Section "Command Line Options") does not contain several of the
options that have been added recently.
More precisely, this list does not mention options with "long form"
that start with `--`, and does not list any of these options.
Should we extend the list in the manual,
or should we perhaps better refer to the list printed by the `-h`
(or `--help`) option?

resolves gap-system#4448
@ThomasBreuer ThomasBreuer added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: build system release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels May 6, 2021
@wilfwilson
Copy link
Member

The issue of documenting the long form command line options was raised in #4197.

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except I'd print the result to stdout, not stderr, as it is expected output, not an error.

The test failure is not caused by this PR and hopefully PR #4468 will fix it.

lib/system.g Outdated Show resolved Hide resolved
lib/system.g Outdated Show resolved Hide resolved
- write `--print-gaproot` output to `*stdout*` not to `*errout*`
- write an error message if `--print-gaproot` fails
Copy link
Member

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me, and the --help text appears nicely.

@fingolfin fingolfin merged commit 49e62b4 into gap-system:master May 11, 2021
@ThomasBreuer ThomasBreuer deleted the TB_print-gaproot branch May 11, 2021 22:03
@fingolfin fingolfin changed the title added the command line option --print-gaproot Add command line option --print-gaproot Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements kind: new feature release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add command line option for querying "the" (primary) GAP root directory
3 participants