Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GAP_CallFunc[0-3]Args #4501

Merged
merged 1 commit into from
May 21, 2021
Merged

Conversation

fingolfin
Copy link
Member

This are purely for convenience, to avoid the need to create a C array of arguments.

@embray might be interested

This are purely for convenience, to avoid the need to create
a C array of arguments.
@fingolfin fingolfin added topic: kernel topic: libgap things related to libgap labels May 19, 2021
@fingolfin fingolfin added this to TODO in LibGAP via automation May 19, 2021
@embray
Copy link
Contributor

embray commented May 20, 2021

This could be useful in a few places where GAP_CallFunc is used directly, though for calling an arbitrary GAP function the more general array-based interface is the most useful. In the current gappy I found only 5 instances of GAP_CallFuncArray all with either 1 or 2 arguments, so this would be a minor convenience there.

LibGAP automation moved this from TODO to Approved May 21, 2021
@fingolfin fingolfin merged commit 9da94fb into gap-system:master May 21, 2021
LibGAP automation moved this from Approved to Done May 21, 2021
@fingolfin fingolfin deleted the mh/libgap-callfunc branch May 21, 2021 17:55
@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Aug 17, 2022
@fingolfin fingolfin changed the title libgap: add GAP_CallFunc[0-3]Args Add GAP_CallFunc[0-3]Args Aug 17, 2022
@fingolfin fingolfin removed the kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: kernel topic: libgap things related to libgap
Projects
LibGAP
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants