Change the *default* representation for perfect groups to IsPermGroup (previously IsFpGroup)
#4506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulpke
added
kind: enhancement
The default choice of representation used by the perfect groups library is as finitely presented group. (This was decided by V. Felsch, when he implemented this library in the 1990s.) However, short of constructing or storing, this representation is almost universally inferior to a permutation representation. This commit thus switches this default.
wilfwilson
approved these changes
May 25, 2021
fingolfin
approved these changes
May 25, 2021
fingolfin
changed the title
IsPermGroup (previously IsFpGroup)
fingolfin
added
release notes: use title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default choice of representation used by the perfect groups library is
as finitely presented group. (This was decided by V. Felsch, when he
implemented this library in the 1990s.)
However, short of constructing or storing, this representation is almost
universally inferior to a permutation representation. This commit thus
switches this default.