Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all perfect groups of orders $10^6$ till $2*10^6$ #4530

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

hulpke
Copy link
Contributor

@hulpke hulpke commented Jun 1, 2021

Two data files for particular orders are kept separately for individual
download, as they are very large.

Two data files for particular orders are kept separately for individual
download, as they are very large.

Changed tests whose output now is longer and
Manual example cannot run over whole library -- will cause error since not
all default.
Copy link
Member

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this.

These files seem to be 12.3MB and 51.7MB each, and so I think distributing them separately is a sensible approach.

@hulpke hulpke merged commit 003bb28 into gap-system:master Jun 7, 2021
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition.

By how much does this PR increase the size of the grp directory (and hence of the GAP distribution)?

"and put it in the `grp` subdirectory of your GAP installation. Then",
" type \n\nreturn;\n\n",
"to continue in this GAP session ",
"(which will read in the file).\n\n\n");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed reasonable for now, and we can easily replace this with something "better" (whatever that'll mean) once/if we have anything.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. My first idea for "better" was NrPerfectLibraryGroups could check if the files are available. Back when the perfect groups library had holes in it, I used NrPerfectLibraryGroups to run tests or searches over the library. I agree the current message is very clear and very informative for an interactive session. I followed the instructions, used return and the search continued without any trouble.

## It contains the perfect groups of order 1975680
## This data was computed by Alexander Hulpke
## It is distributed under the artistic license 2.0
## https://opensource.org/licenses/Artistic-2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, that's a problem from a legal point of view. Right now we claim "GAP is GPL 2", period, without any differentation. And that's correct at least for core GAP (not for package). This PR changes that. This will require some extra changes. I can help with those, but this is a blocker for a release, IMHO.

@wilfwilson
Copy link
Member

It seems to be that the increase in size (for the newly included files in the range perf24.grp -- perf34.grp) is about 3.5MB total.

@jackschmidt
Copy link
Contributor

FWIW, I checked that all of the groups have the claimed order and are perfect. The default method for PerfectIdentification needs to be updated to the new upper limit. I am planning on seeing if my old perfect identification code (never submitted) can be updated to prove non-isomorphism and provide a faster id.

@wilfwilson wilfwilson added release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes release notes: highlight PRs introducing changes that should be highlighted at the top of the release notes labels Jun 10, 2021
@fingolfin fingolfin changed the title ENHANCE: Perfect groups of orders 10^6-2*10^6. Add all perfect groups of orders $10^6$ till $2*10^6$ Aug 17, 2022
@fingolfin fingolfin added release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: new feature release notes: highlight PRs introducing changes that should be highlighted at the top of the release notes release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants