Add IsQuasisimpleGroup, IsQuasisimpleCharacterTable
#4653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and fixed a bug due to a wrong implication (which apparently nobody has noticed up to now)
ThomasBreuer
added
kind: enhancement
(This commit covers just the obvious fixes, not the difference mentioned in issue gap-system#4656.)
fingolfin
reviewed
Sep 15, 2021
There was a problem hiding this comment.
There is a still a diff in an example (very annoying, maybe we should turn off the output of that example):
gap> ########> Diff in /home/runner/work/gap/gap/tst/testmanuals/ref-chapter03\
9.tst/home/runner/work/gap/gap/doc/ref/../../lib/grp.gd:3304:615
# Input is:
PCentralSeries(g,2);
# Expected output:
[ Sym( [ 1 .. 4 ] ), Group([ (1,2,3), (2,3,4) ]) ]
# But found:
[ Sym( [ 1 .. 4 ] ), Group([ (1,2,3), (1,3,4) ]) ]
########
fingolfin
approved these changes
Sep 18, 2021
One of them (an example for `NormalSubgroups`) was failing in the CI tests, the other (an example for `CharacteristicSubgroups`) was not (yet) failing but it was clearly intended to be viewed together with the first one.
fingolfin
changed the title
IsQuasisimpleGroup, IsQuasisimpleCharacterTableIsQuasisimpleGroup, IsQuasisimpleCharacterTable
fingolfin
removed
the
kind: bug: wrong result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and fixed a bug due to a wrong implication (which apparently nobody has noticed up to now)