Fix (rare) wrong result for stabilizer computations #4660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulpke
added
release notes: to be added
fingolfin
added
the
kind: bug: wrong result
fingolfin
changed the title
fingolfin
reviewed
Sep 18, 2021
fingolfin
reviewed
Sep 18, 2021
| @@ -2056,11 +2056,16 @@ end ); | |||
| ## | |||
| #F DixonSplit(<D>) . . calculate matrix,split spaces and obtain characters | |||
| ## | |||
| InstallGlobalFunction( DixonSplit, function(D) | |||
| local r,i,j,ch,ra,bsm, | |||
| InstallGlobalFunction( DixonSplit, function(arg) | |||
There was a problem hiding this comment.
This is never called with the new argument, though, right? So is this for future work, or just for manual invocations by "super expert users"?
if they are few and would require maximals of lagbe almost simple group.
Handle generators/inverses that get killed Module rules before tails 2-cohom normalform rws *is* created confluent
if trivial image
If the group order is known, the generic orbit stabilizer might stop enumerating the orbit if one can deduce that it could not grow anymore for divisibility reasons. In this case the stabilizer in rare cases might still be too small and need to be corrected. This was done not fully. Thsi fixes gap-system#4659
fingolfin
approved these changes
Sep 21, 2021
fingolfin
changed the title
fingolfin
added
release notes: use title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #4659 and a number of small improvements (which are added so I don't need to wait for another approving review)
Text for release notes