Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify documentation of IsFFECollection #4672

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Clarify documentation of IsFFECollection #4672

merged 1 commit into from
Oct 12, 2021

Conversation

ssiccha
Copy link
Contributor

@ssiccha ssiccha commented Oct 12, 2021

For example

gap> IsFFECollection([Z(2), Z(2)]);
true
gap> IsFFECollection([Z(3), Z(2)]);
false

@ssiccha
Fix documentation of IsFFECollection
6f18ec2 
For example

    gap> IsFFECollection([Z(2), Z(2)]);
    true
    gap> IsFFECollection([Z(3), Z(2)]);
    false
@ssiccha ssiccha added the release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes label Oct 12, 2021
FriedrichRober
FriedrichRober approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@FriedrichRober FriedrichRober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@fingolfin fingolfin merged commit 3123cd9 into gap-system:master Oct 12, 2021
@ThomasBreuer
Copy link
Contributor

@ssiccha I would not call this a fix.
The list [Z(3), Z(2)] in your example is not a collection, and this fact is stated in the sentence above the one which you have changed.

@fingolfin
Copy link
Member

Agreed, it isn't a fix, but still an improvement :-)

@fingolfin fingolfin changed the title Fix documentation of IsFFECollection Fix documentation of IsFFECollection Aug 17, 2022
@fingolfin fingolfin changed the title Fix documentation of IsFFECollection Clarify documentation of IsFFECollection Aug 17, 2022
@fingolfin fingolfin added the topic: documentation Issues and PRs related to documentation label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

@FriedrichRober FriedrichRober FriedrichRober approved these changes

@AnnaKDS AnnaKDS Awaiting requested review from AnnaKDS

@danielrademacher danielrademacher Awaiting requested review from danielrademacher

@wucas wucas Awaiting requested review from wucas

Assignees
No one assigned
Labels
release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: documentation Issues and PRs related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ssiccha @ThomasBreuer @fingolfin @FriedrichRober