Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Coefficients for large finite fields created via a polynomial #4703

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Fix Coefficients for large finite fields created via a polynomial #4703

merged 1 commit into from
Nov 17, 2021

Conversation

ThomasBreuer
Copy link
Contributor

resolves #4694

@ThomasBreuer ThomasBreuer added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them topic: library release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Nov 16, 2021
fingolfin
fingolfin approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@fingolfin fingolfin merged commit fcdcf8f into gap-system:master Nov 17, 2021
@ThomasBreuer ThomasBreuer deleted the TB_Coefficients_for_GF branch November 17, 2021 10:39
@fingolfin fingolfin changed the title fixed Coefficients for large finite fields created via a polynomial Fix Coefficients for large finite fields created via a polynomial Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

problem with bases of finite fields that are constructed using prescribed polynomials
2 participants
@ThomasBreuer @fingolfin