Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance SimplifiedFpGroup and IsomorphismSimplifiedFpGroup to transfer attributes (such as size, being abelian etc.) to the simplified group #4810

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Enhance SimplifiedFpGroup and IsomorphismSimplifiedFpGroup to transfer attributes (such as size, being abelian etc.) to the simplified group #4810

merged 1 commit into from
Mar 3, 2022

Conversation

fingolfin
Copy link
Member

No description provided.

@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: library labels Mar 2, 2022
@fingolfin fingolfin changed the title Let (Isomorphism)SimplifiedFpGroup transfer attributes to the simplified group Let SimplifiedFpGroup and IsomorphismSimplifiedFpGroup transfer attributes (such as size, being abelian etc.) to the simplified group Mar 2, 2022
hulpke
hulpke reviewed Mar 2, 2022
View reviewed changes
Copy link
Contributor

@hulpke hulpke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It it clear that UseIsomorphismRelation does not do anything (such as comparing elements) which could cause problems for fp groups?

@fingolfin
Copy link
Member Author

It should: It purely transfers select filters/properties/attributes installed via InstallIsomorphismMaintenance or InstallFactorMaintenance. I.e. if one of these is set for the one group, it is set identical for the other.

The only hypothetical problem I can think of would be if this leads to some immediate method triggering that does something problematic. But I'd say this then would be a problem with that immediate method, which should be resolved with that.

hulpke
hulpke approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@hulpke hulpke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you -- this should be all safe.

@fingolfin fingolfin force-pushed the mh/improve-SimplifiedFpGroup branch from 39eda51 to ba9d31f Compare March 2, 2022 22:23
@fingolfin fingolfin force-pushed the mh/improve-SimplifiedFpGroup branch from ba9d31f to f2e6d42 Compare March 2, 2022 22:23
@fingolfin fingolfin merged commit 92bd002 into gap-system:master Mar 3, 2022
@fingolfin fingolfin deleted the mh/improve-SimplifiedFpGroup branch March 3, 2022 02:36
@fingolfin fingolfin changed the title Let SimplifiedFpGroup and IsomorphismSimplifiedFpGroup transfer attributes (such as size, being abelian etc.) to the simplified group Enhance SimplifiedFpGroup and IsomorphismSimplifiedFpGroup to transfer attributes (such as size, being abelian etc.) to the simplified group Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hulpke hulpke hulpke approved these changes

Assignees
No one assigned
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fingolfin @hulpke