Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up computation of the intersection of group cosets in the generic cases and even more so for permutation groups #4874

Merged
merged 20 commits into from
Jun 3, 2022
Merged

Speed up computation of the intersection of group cosets in the generic cases and even more so for permutation groups #4874

merged 20 commits into from
Jun 3, 2022

Commits on Jun 1, 2022

  1. Add more code for the Intersection of cosets. 

    Co-authored-by: Max Horn <max@quendi.de>
    @MathieuDutSik @fingolfin
    MathieuDutSik and fingolfin committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    4ca9138 View commit details
    Browse the repository at this point in the history

  2. Some small correction to the CI.

    @MathieuDutSik @fingolfin
    MathieuDutSik authored and fingolfin committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    91abdb2 View commit details
    Browse the repository at this point in the history

  3. More correction.

    @MathieuDutSik @fingolfin
    MathieuDutSik authored and fingolfin committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    b78c40c View commit details
    Browse the repository at this point in the history

  4. Correct the cset in order to avoid the strange formatting errors.

    @MathieuDutSik @fingolfin
    MathieuDutSik authored and fingolfin committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    55f772c View commit details
    Browse the repository at this point in the history

  5. Add more tests for the rightcosets.

    @MathieuDutSik @fingolfin
    MathieuDutSik authored and fingolfin committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    711ee32 View commit details
    Browse the repository at this point in the history

  6. More insertions of tests and typo correction from Christopher Jefferson.

    @MathieuDutSik @fingolfin
    MathieuDutSik authored and fingolfin committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    5feaec4 View commit details
    Browse the repository at this point in the history

  7. Renaming the variables.

    @MathieuDutSik @fingolfin
    MathieuDutSik authored and fingolfin committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    fa02b77 View commit details
    Browse the repository at this point in the history

  8. Update lib/csetperm.gi 

    Co-authored-by: Max Horn <max@quendi.de>
    @MathieuDutSik @fingolfin
    MathieuDutSik and fingolfin committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    afb41af View commit details
    Browse the repository at this point in the history

  9. More Corrections.

    @MathieuDutSik @fingolfin
    MathieuDutSik authored and fingolfin committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    6908bb4 View commit details
    Browse the repository at this point in the history

  10. More cases being covered by tests, improving test coverage.

    @MathieuDutSik @fingolfin
    MathieuDutSik authored and fingolfin committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    422d6c4 View commit details
    Browse the repository at this point in the history

  11. Limit the computation of grpInt as to when needed.

    @MathieuDutSik @fingolfin
    MathieuDutSik authored and fingolfin committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    0492dbf View commit details
    Browse the repository at this point in the history

  12. Reduce no longer needed code.

    @MathieuDutSik @fingolfin
    MathieuDutSik authored and fingolfin committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    5a84769 View commit details
    Browse the repository at this point in the history

  13. Correction of the test in order to pass the CI.

    @MathieuDutSik @fingolfin
    MathieuDutSik authored and fingolfin committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    7694745 View commit details
    Browse the repository at this point in the history

  14. Add more tests.

    @MathieuDutSik @fingolfin
    MathieuDutSik authored and fingolfin committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    953e883 View commit details
    Browse the repository at this point in the history

  15. Finish the covering of all cases.

    @MathieuDutSik @fingolfin
    MathieuDutSik authored and fingolfin committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    de2591b View commit details
    Browse the repository at this point in the history

  16. Add the additional test by Max Horn.

    @MathieuDutSik @fingolfin
    MathieuDutSik authored and fingolfin committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    38d543a View commit details
    Browse the repository at this point in the history

  17. Add and use TestIntersection helper

    @fingolfin
    fingolfin committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    fa3f26d View commit details
    Browse the repository at this point in the history

  18. Align the two coset intersection methods; add some comments; restore … 

    …a removed criterion
    @fingolfin
    fingolfin committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    8df199e View commit details
    Browse the repository at this point in the history

  19. Tweak generic coset Intersection2 

    Add a heuristic to fall back to the previous method if it is cheap
    @fingolfin
    fingolfin committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    879672c View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Add some more comments, rename some local variables

    @fingolfin
    fingolfin committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    b953e0a View commit details
    Browse the repository at this point in the history