Improve gac to print errors to stderr and in color
#4933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new helper function `echo_and_run` which first prints its arguments, then execute them as if they were a single command invocation.
ChrisJefferson
approved these changes
Jul 8, 2022
Closed
fingolfin
changed the title
gac to print errors to stderr and in color
fingolfin
added
the
release notes: use title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new helper function
echo_and_runwhich first prints itsarguments, then execute them as if they were a single command invocation.
Does some of the things mentioned in issue #4932, but not the central point there (quiet mode).
In principle the coloring and the new helper are independent, and if only one is to be merged, that could be done; for now I couldn't be bothered to untangle these changes.
Should probably add some tests ... but not sure I can be bothered...