Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance regression in AllHomomorphismClasses and possibly other code searching isomorphisms #5032

Merged

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Sep 5, 2022

Since this is costly, it is worth to force a minimal generating set for
solvable groups. This resolves problems the yangbaxter package has had.

Close #5024

This patch is taken from @hulpke's PR #5031, but having different, unrelated improvements and bug fixes on separate PRs reduces the work needed to make GAP releases quite a bit (as it allows us to deal with those PRs in automation, instead of adding them to the list of PRs that need manual work), and is also more convenient for reviewers, so I am splitting it off here.

For reference, here is the motivation for this patch from the description of PR #5024:

The early abort condition Length(gens)<=Length(AbelianInvariants(G))+2
was inserted in 9d380c4 to speed up
calculations in certain large cases. However this caused regressions
in various package test suites, so bdf94cb
attempted to address this by reordering some computations. Alas, that
was not enough: the YangBaxter test suite got slowed down by an order of
magnitude (it went from about 30 seconds to several minutes on my laptop).

This PR addresses this.

Since this is costly, it is worth to force a minimal generating set for
solvable groups. This resolves problems the yangbaxter package has had.

Close gap-system#5024
@fingolfin fingolfin added regression A bug that only occurs in the branch, not in a release topic: performance bugs or enhancements related to performance (improvements or regressions) release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes backport-to-4.12 labels Sep 5, 2022
@fingolfin fingolfin enabled auto-merge (rebase) September 7, 2022 12:41
@fingolfin fingolfin merged commit f2b8fca into gap-system:master Sep 7, 2022
@fingolfin fingolfin deleted the mh/workaround-for-yang-baxter branch September 7, 2022 12:44
@fingolfin
Copy link
Member Author

Backported to stable-4.12 via fa8d50a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-4.12-DONE regression A bug that only occurs in the branch, not in a release release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: performance bugs or enhancements related to performance (improvements or regressions)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants