Fix unexpected error in MinimalGeneratingSet for solvable non-pc groups
#5041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: bug
…oups It could end up returning nothing and not invoking TryNextMethod(). This caused a failure in the hap test suite. This is a recent regression in 4.12.0.
fingolfin
force-pushed
the
mh/fix-MinimalGeneratingSet
branch
from
f7e88ec
to
94ea907
Compare
ThomasBreuer
approved these changes
Sep 9, 2022
|
Backported to stable-4.12 via d11ab96 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could end up returning nothing and not invoking TryNextMethod().
This caused a failure in the hap test suite.
This is a recent regression in 4.12.0, introduced in commit 97feedb