Fix SaveOnExitFile in restored workspaces
#5043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and possibly more errors: we accidentally removed all exit handlers when quitting GAP, just before the workspace was saved, thus when restoring GAP from this session, those exist handlers were missing, including the one dealing with `SaveOnExitFile`. This code looses the ability to install new exit handlers as part of an exit handler, but that seems like a rather bad (and pointless) idea to me anyway.
fingolfin
added
kind: bug
|
My thought was that AtExit functions should only be run once, so I didn't need to look after the list, but I see that's not true. We might want to add something to do the docs of AtExit saying they may be run more than once (although now I think about this, this was always true with saved workspaces, so this isn't a new problem). I just went and checked and I think our current ones are all OK. The main one that worried me was |
ChrisJefferson
approved these changes
Sep 9, 2022
|
Backported to stable-4.12 via c1009a2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and possibly more errors: we accidentally removed all exit handlers when quitting GAP, just before the workspace was saved, thus when restoring GAP from this session, those exist handlers were missing, including the one dealing with
SaveOnExitFile.This code looses the ability to install new exit handlers as part of an exit handler, but that seems like a rather bad (and pointless) idea to me anyway.
Fixes #5035