Fix printing of GAP functions containing sublist extractions #5116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zickgraf
force-pushed
the
nested_sublist_printing
branch
from
690a68b
to
17e920a
Compare
fingolfin
reviewed
Oct 18, 2022
zickgraf
force-pushed
the
nested_sublist_printing
branch
from
79b1657
to
801d5fa
Compare
* PrintElmsListLevel preserves the old behaviour of PrintElmsList for EXPR_ELMS_LIST_LEV. * PrintElmsList applies to EXPR_ELMS_LIST and now checks if its first argument is of type EXPR_ELMS_LIST or EXPR_ELMS_LIST_LEV. If yes, the list is put in brackets.
zickgraf
force-pushed
the
nested_sublist_printing
branch
from
801d5fa
to
9d690f4
Compare
|
I have now included all combinations which do not crash due to #5117 in the tests. |
fingolfin
added
kind: bug
fingolfin
changed the title
|
Backported to stable-4.12 in commit 333aafc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text for release notes
see title
Further details
I'm not sure this works for all cases, but I currently cannot inspect the internals of some cases due to getting a segfault (#5117). From my testing it seems that everything works fine, even for deeply nested cases.
Fixes #5109.