Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashes in ConvertToVectorRep and CopyToVectorRep #5126

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Fix crashes in ConvertToVectorRep and CopyToVectorRep #5126

merged 1 commit into from
Oct 19, 2022

Conversation

fingolfin
Copy link
Member

Fixes #5123

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: crash Issues describing bugs that cause GAP to crash, and PRs fixing them (used for release notes) release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes backport-to-4.12 labels Oct 18, 2022
@fingolfin fingolfin added the gapdays2022-summer Issues and PRs that arose at https://www.gapdays.de/gapdays2022-summer label Oct 18, 2022
ThomasBreuer
ThomasBreuer approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this fixes the crashes.
Additionally, the check for the containment of the finite fields makes the example from issue #5123 work, thus it is in fact not needed to adjust the GAP function ConvertToVectorRep.
Very nice.

@ThomasBreuer ThomasBreuer merged commit 8ff1324 into gap-system:master Oct 19, 2022
@fingolfin fingolfin deleted the mh/fix-RewriteVec8Bit branch October 20, 2022 11:21
@fingolfin
Copy link
Member Author

Backported to stable-4.12 in commit fb6f05c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasBreuer ThomasBreuer ThomasBreuer approved these changes

Assignees
No one assigned
Labels
backport-to-4.12-DONE gapdays2022-summer Issues and PRs that arose at https://www.gapdays.de/gapdays2022-summer kind: bug: crash Issues describing bugs that cause GAP to crash, and PRs fixing them (used for release notes) kind: bug Issues describing general bugs, and PRs fixing them release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

problem with compressed vectors
2 participants
@fingolfin @ThomasBreuer