Check when we build a library, it functions correctly (in particular gmp) #5720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
make check
whenever we build zlib or gmp as an external dependancy.This will, hopefully, catch if we end up with an out-of-date gmp. This could probably be improved to explain to users why compiling is braking, and suggest they go and suggest they install the approriate library themselves?
Check it works by not installing gmp on mac.