Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NameIsomorphismClass #597

Merged

Conversation

fingolfin
Copy link
Member

Remove the undocumented attribute "NameIsomorphismClass". It was added
2000-01-05 by Hans Ulrich Besche, and always was marked as experimental.
Furthermore, it was only available as a pre-computed value for pc groups
constructed via CyclicGroup, and some groups constructed via SmallGroup.

As a replacement, you can use StructureDescription.

The only user visible change is that the output of SmallGroupsInformation
for products of three distinct primes does not list the isomorphism classes
anymore. But since other SmallGroupsInformation methods also don't do
that, this seems like an acceptable loss.

Remove the undocumented attribute "NameIsomorphismClass". It was added
2000-01-05 by Hans Ulrich Besche, and always was marked as experimental.
Furthermore, it was only available as a pre-computed value for pc groups
constructed via `CyclicGroup`, and some groups constructed via `SmallGroup`.

As a replacement, you can use StructureDescription.

The only user visible change is that the output of `SmallGroupsInformation`
for products of three distinct primes does not list the isomorphism classes
anymore. But since other `SmallGroupsInformation` methods also don't do
that, this seems like an acceptable loss.
@olexandr-konovalov
Copy link
Member

@fingolfin thanks. So, as the consequence, instead of e.g.

gap> SmallGroupsInformation(2*5*19);

  There are 4 groups of order 190.
    1 is of type D10x19.
    2 is of type D38x5.
    3 - 3 are of types 5:2+19:2.
    4 is of type c190.

  The groups whose order factorises in at most 3 primes 
  have been classified by O. Hoelder. This classification is 
  used in the SmallGroups library. 

  This size belongs to layer 1 of the SmallGroups library. 
  IdSmallGroup is available for this size. 

we will have just

gap> SmallGroupsInformation(2*5*19);

  There are 4 groups of order 190.

  The groups whose order factorises in at most 3 primes 
  have been classified by O. Hoelder. This classification is 
  used in the SmallGroups library. 

  This size belongs to layer 1 of the SmallGroups library. 
  IdSmallGroup is available for this size. 

My first reaction was that I don't want to lose this functionality, but then I started to think that its format is not unified with StructureDescription; bringing it to the same form may require an extra work; OTOH, StructureDescription works just fine for these groups, and their number does not constitute a computational challenge. So I agree with @fingolfin that this is an "acceptable loss".

ChrisJefferson added a commit that referenced this pull request Feb 9, 2016
@ChrisJefferson ChrisJefferson merged commit 012911e into gap-system:master Feb 9, 2016
@fingolfin fingolfin deleted the mh/remove-NameIsomorphismClass branch February 10, 2016 18:06
@olexandr-konovalov olexandr-konovalov added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants