Collection of enhancements #683
Conversation
|
This looks good to me. I would be interested in cases where |
|
@ChrisJefferson Thank you. Indeed when I created it I was hoping that someone who knows the backtrack better would implement a backtrack replacement (or have a backtrack method). Currently it is only used in the library in the automorphism group calculation for solvable groups -- to descend from GL to a subgroup stabilizing certain subspaces. |
hulpke
force-pushed
the
additions
branch
2 times, most recently
from
979d050
to
d69be4b
Compare
Also works (through maximal subgroups) for e.g. permutation groups.
Run through subsets by order.
if it is too large.
Use actual extension names used by table of marks library to avoid issues of assigning fixed names. Catch cases of TableOfMarks returning fail.
|
@hulpke, it seems that this PR now causes the following diff: |
|
@hulpke As this PR now merged, could you please document those changes that are worth highlighting in the changes manual and GAP 4.9 release announcement? The easiest way is to list them on wiki here: https://github.com/gap-system/gap/wiki/Changes-between-GAP-4.8-and-GAP-4.9 |
|
@alex-konovalov I suspect the error in grpperm.tst is due to fixes that are in stable, but not yet in master. Should I submit the same changes as a pull request to master, or will there be an automatic merge from stable to master in the foreseeable future? |
|
@hulpke there are no such things like "automatic" merges, but the right adjective to use would be "periodic merges". Time to time someone should make them. Sometimes they could go without merge conflicts, but now now - this is because of taking some HPC-GAP extensions out of the stable branch. In any case, you don't have to submit another PR or do any cherry-picking for the changes that are already in the stable branch, since the merge should pick up those changes. |
olexandr-konovalov
added
the
release notes: added
For some reason (probably my stupidity) par on gap-system#683 had fallen out of master. Add again.
as requested in gap-system#2131 Also added `LowLayerSubgroups` and minor rephrasing. Also redid part of gap-system#683, as for some reason (probably my stupidity) part of gap-system#683 had fallen out of master. Added it again.
For some reason (probably my stupidity) par on gap-system#683 had fallen out of master. Add again.
as requested in gap-system#2131 Also added `LowLayerSubgroups` and minor rephrasing. Also redid part of gap-system#683, as for some reason (probably my stupidity) part of gap-system#683 had fallen out of master. Added it again.
as requested in gap-system#2131 Also added `LowLayerSubgroups` and minor rephrasing. Also redid part of gap-system#683, as for some reason (probably my stupidity) part of gap-system#683 had fallen out of master. Added it again.
as requested in gap-system#2131 Also added `LowLayerSubgroups` and minor rephrasing. Also redid part of gap-system#683, as for some reason (probably my stupidity) part of gap-system#683 had fallen out of master. Added it again.
as requested in gap-system#2131 Also added `LowLayerSubgroups` and minor rephrasing. Also redid part of gap-system#683, as for some reason (probably my stupidity) part of gap-system#683 had fallen out of master. Added it again.
No description provided.