Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in OnSetsPerm #731

Merged
merged 1 commit into from
Apr 14, 2016
Merged

Conversation

james-d-mitchell
Copy link
Contributor

Before this change, I get:

gap> InstallOtherMethod(POW, "for a character and perm",
> [IsChar, IsPerm],
> function(char, p)
>   return 1;
> end);
gap>
gap> OnSets("abc", (1,2));
[ 1, 131135, 1, 393219, <lvars bag> ]
gap>

Because the length of the output list is not properly set in the function OnSetsPerm in permutat.c. This PR fixes this issue. I haven't added a test because I wouldn't want to install the method for POW given above.

When the set acted does not contain positive integers.
@markuspf markuspf merged commit 3b1d13d into gap-system:master Apr 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants