Fix some bugs in the Rees (0)-matrix semigroups code #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a bit dubious about the Immediate method for finiteness. Couldn't one create a Rees matrix semigroup over a group that takes a very long time to decide whether it's finite (or, as it were, can't decide whether its finite)? (Maybe I still don't understand immediate methods...) |
Added some tests too, formerly the tests ran into infinite recursion.
james-d-mitchell
force-pushed
the
fix-reesmat
branch
from
b610f9c
to
3387f6f
Compare
|
@markuspf You're completely correct, I just updated this to check if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes some bugs in the Rees (0-) matrix semigroup code related to creating such semigroups over infinite groups or semigroups.
Tests are added which test cases that previously failed, these were pointed out by Wilf Wilson.